----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/#review207525 -----------------------------------------------------------
src/slave/container_loggers/lib_logrotate.cpp Line 169 (original), 171 (patched) <https://reviews.apache.org/r/68397/#comment290928> You don't need this `cloexec` here any more because `os::pipe()` has already done it. src/slave/container_loggers/lib_logrotate.cpp Line 201 (original), 203 (patched) <https://reviews.apache.org/r/68397/#comment290929> Here, you need to use the `UNSET_CLOEXEC` child hook to pass the child end of the pipe? - James Peach On Aug. 16, 2018, 11:18 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68397/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 11:18 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin > Mahler, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9151 > https://issues.apache.org/jira/browse/MESOS-9151 > > > Repository: mesos > > > Description > ------- > > Updated the ::pipe() system calls to pipe2 in lib_logrotate. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.cpp > fa71e07290413ae0670f9879cec60f59de005adb > > > Diff: https://reviews.apache.org/r/68397/diff/1/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
