----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63270/#review207549 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Aug. 17, 2018, 5:53 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63270/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 5:53 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin > Mahler, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8128 > https://issues.apache.org/jira/browse/MESOS-8128 > > > Repository: mesos > > > Description > ------- > > Updated `os::pipe()` to always return O_CLOEXEC descriptors, > atomically if we are on Linux or FreeBSD and the `pipe2(2)` > system call is available. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/pipe.hpp > ac76224ff8fa1cc535c78731580e77a27967136a > > > Diff: https://reviews.apache.org/r/63270/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
