----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68410/#review207556 -----------------------------------------------------------
src/slave/slave.cpp Lines 8040 (patched) <https://reviews.apache.org/r/68410/#comment290945> According to `mesos.proto`, `OPERATION_GONE_BY_OPERATOR` is not terminal, similar to `TASK_GONE_BY_OPERATOR`: https://github.com/apache/mesos/blob/808485da01387bd27a51cb82a90b1f8301d613ee/include/mesos/mesos.proto#L2342-L2349 IIRC the reason is that we have a fixed-size circular buffer for gone agent IDs. Let's either update the above comment or use a new section for this case. - Chun-Hung Hsiao On Aug. 17, 2018, 1:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68410/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 1:53 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and Greg Mann. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > Made OPERATION_GONE_BY_OPERATOR a terminal operation status update. > > > Diffs > ----- > > src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c > > > Diff: https://reviews.apache.org/r/68410/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
