----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207605 -----------------------------------------------------------
src/master/http.cpp Line 3031 (original), 3030 (patched) <https://reviews.apache.org/r/68343/#comment291054> s/] (/]( src/master/http.cpp Line 3031 (original), 3030-3031 (patched) <https://reviews.apache.org/r/68343/#comment291055> Is pass-by-value intentional? src/master/master.hpp Lines 1389-1390 (patched) <https://reviews.apache.org/r/68343/#comment291056> corresponding what? src/master/master.hpp Lines 1398 (patched) <https://reviews.apache.org/r/68343/#comment291058> On the previous line please. - Alexander Rukletsov On Aug. 17, 2018, 7:06 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68343/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 7:06 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > In preparation for the changes in the subsequent commit, > the serialization logic was moved from an inner lambda > to a separate function. > > > Diffs > ----- > > src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 > src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d > > > Diff: https://reviews.apache.org/r/68343/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >