----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68348/#review207618 -----------------------------------------------------------
PASS: Mesos patch 68348 was successfully built and tested. Reviews applied: `['68256', '68257', '68408', '68348']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2197/mesos-review-68348 - Mesos Reviewbot Windows On Aug. 14, 2018, 5:26 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68348/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 5:26 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-9116 > https://issues.apache.org/jira/browse/MESOS-9116 > > > Repository: mesos > > > Description > ------- > > Previously, we were calling `getMountNamespaceTarget()` not only in > case of the command executor but in all other cases too, including > the default executor. That might lead to various subtle bugs, caused by > wrong detection of `mnt` namespace target. This patch fixes the issue > by setting a parent PID as `mnt` namespace target in case of > non-command executor task. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 98129d006cda9b65804b518619b6addc8990410a > > > Diff: https://reviews.apache.org/r/68348/diff/3/ > > > Testing > ------- > > 1. sudo make check (Fedora 25) > 2. internal CI > > This test fixes `ROOT_CGROUPS_LaunchNestedDebugAfterUnshareMntNamespace` > test, which can be found in the previous patch. > > > Thanks, > > Andrei Budnik > >
