> On Aug. 21, 2018, 6:27 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp > > Lines 1401-1404 (original), 1401-1410 (patched) > > <https://reviews.apache.org/r/68321/diff/2/?file=2074732#file2074732line1401> > > > > How about moving definitions on this class's methods to a separate > > file, e.g., "readonly_handlers.cpp"?
Sounds good, but I'll do it bundled at the end of the review chain. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/#review207650 ----------------------------------------------------------- On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68321/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2018, 2:09 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-9158 > https://issues.apache.org/jira/browse/MESOS-9158 > > > Repository: mesos > > > Description > ------- > > Added '/state-summary' to the set of batched master endpoints. > > > Diffs > ----- > > src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc > src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 > > > Diff: https://reviews.apache.org/r/68321/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
