> On Aug. 17, 2018, 12:59 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 825-827 (patched) > > <https://reviews.apache.org/r/68414/diff/1/?file=2074711#file2074711line839> > > > > Can you add some comments on why we use the registration backoff factor > > here instead of the authentication one? Is there a ticket we can point to > > suggesting the fix to have the authentication path not use the registration > > factor? > > > > Also, for these, it would be helpful to know why the factor is enough, > > isn't the first window `[min,min+factor*2^0]`?
Done. Filed MESOS-9173. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68414/#review207536 ----------------------------------------------------------- On Aug. 21, 2018, 2:18 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68414/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2018, 2:18 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > This patch pauses and manipulates the clock for all > authentication tests. This makes the test less flaky-prone > and speeds up the test run time. > > > Diffs > ----- > > src/tests/authentication_tests.cpp f7a2cf17cf6154c9c67e405661bba57cf1254845 > > > Diff: https://reviews.apache.org/r/68414/diff/2/ > > > Testing > ------- > > make check, and authentication tests ran continously without failure. > > Authentication test took: > before: 0m15.282s > after: 0m6.847s > > > Thanks, > > Meng Zhu > >
