----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68473/#review207743 -----------------------------------------------------------
Bad review! Reviews applied: [68473] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot Windows On Aug. 22, 2018, 2:25 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68473/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 2:25 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Moved the member functions of class ReadOnlyHandler into > the new file `readonly_handler.cpp`. This follows the pattern > established by `weights_handler.cpp` and `quota_handler.cpp`. > > As part of this move, it was also necessary to move some JSON > serialization helpers that are used from both `master.cpp` and > `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}` > that can be used from both places. > > > Diffs > ----- > > src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb > src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 > src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c > src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 > src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc > src/master/json.hpp PRE-CREATION > src/master/json.cpp PRE-CREATION > src/master/readonly_handler.cpp PRE-CREATION > src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 > > > Diff: https://reviews.apache.org/r/68473/diff/1/ > > > Testing > ------- > > `make` > > > Thanks, > > Benno Evers > >
