----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207797 -----------------------------------------------------------
Patch looks great! Reviews applied: [68366] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 23, 2018, 2:56 a.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68366/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2018, 2:56 a.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-9133 > https://issues.apache.org/jira/browse/MESOS-9133 > > > Repository: mesos > > > Description > ------- > > Added the `--container_ports_isolated_range` flag to the > `network/ports` isolator. This allows the operator to specify a custom > port range to be protected by the isolator. If a task listens on a port > that it isn't holding resources for, the isolator will not raise a > limitation unless the port is within this range. We can represent the > `--check_agent_port_range_only` as a special case of a protected range. > > > Diffs > ----- > > docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e > docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768 > src/slave/containerizer/mesos/isolators/network/ports.hpp > 6944d01e0f8a11eda381ef1754f19ee0cf9359c8 > src/slave/containerizer/mesos/isolators/network/ports.cpp > 2a7ff2530f898cf892739c715b07b3387b423ed9 > src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f > src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b > src/tests/containerizer/ports_isolator_tests.cpp > db080c4e9c8b0c036294a8f7a42617ca1231f884 > > > Diff: https://reviews.apache.org/r/68366/diff/7/ > > > Testing > ------- > > New test added to test feature: > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementIsolatedPort > (1678 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1679 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1691 ms total) > [ PASSED ] 1 test. > > Existing test updated to test the negative cases: > > [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (73 ms) > [----------] 1 test from NetworkPortsIsolatorTest (73 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (85 ms total) > [ PASSED ] 1 test. > > Existing test for isolator feature: > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforcement (1789 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1790 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1801 ms total) > [ PASSED ] 1 test. > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1795 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1795 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1806 ms total) > [ PASSED ] 1 test. > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1782 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1783 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1794 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Xudong Ni > >
