> On Aug. 22, 2018, 11:37 p.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 299 (original) > > <https://reviews.apache.org/r/68472/diff/1/?file=2076113#file2076113line299> > > > > The reason to enable this isolator is because we create new mounts when > > launching the CSI plugin container: > > > > https://github.com/apache/mesos/blob/da13db36d9735ec6f03817fb7da8d7e2ef00831c/src/resource_provider/storage/provider.cpp#L1947 > > > > https://github.com/apache/mesos/blob/da13db36d9735ec6f03817fb7da8d7e2ef00831c/src/resource_provider/storage/provider.cpp#L1965 > > If we don't use this isolator, wouldn't the test pollute the host mount > > table? Or are they already taken care of by the test environment teardown? > > > > If not, we need to manually call `unmountAll` in the test teardown > > instead.
It seems I'm mistaken. If the `posix/filesystem` isolator is used instead the volumes will be just symlinked. Dropping this. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68472/#review207778 ----------------------------------------------------------- On Aug. 22, 2018, 10:30 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68472/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 10:30 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > ------- > > These tests required `ROOT` in order to use `filesystem/linux` > isolation this is not a requirement anymore so we can run the tests in > general. These tests appear to be able to run in parallel as well. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 9b88d366df958d938a3a0cac4f64a937c6178ee3 > > > Diff: https://reviews.apache.org/r/68472/diff/1/ > > > Testing > ------- > > `make check` > `GTEST_FILTER='*StorageLocalResourceProviderTest*' > ../support/mesos-gtest-runner.py ./src/mesos-tests` > > > Thanks, > > Benjamin Bannier > >
