----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68502/#review207909 -----------------------------------------------------------
Fix it, then Ship it! Thanks for cleaning this up Benno! 3rdparty/stout/include/Makefile.am Line 27 (original), 27-28 (patched) <https://reviews.apache.org/r/68502/#comment291535> Swap the ordering of these two. 3rdparty/stout/include/stout/circular_buffer.hpp Lines 20-21 (patched) <https://reviews.apache.org/r/68502/#comment291536> I was briefly wondering if these should be `undef`'ed once we have included the Boost header, but what you wrote here is actually the better solution as it would leave the chance for users with different defines seeing redefinition warnings. - Benjamin Bannier On Aug. 24, 2018, 7:38 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68502/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2018, 7:38 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Added a new file `stout/circular_buffer.hpp` that pulls > the `boost::circular_buffer` class into the global namespace > to ensure the boost header is always used with the correct > macro definitions when included from Mesos. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 0a4ea7b16b316cc8a411ac9c4d20783530b7168a > 3rdparty/stout/include/stout/circular_buffer.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68502/diff/2/ > > > Testing > ------- > > See follow-up review r/68503. > > > Thanks, > > Benno Evers > >
