----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68502/#review207916 -----------------------------------------------------------
Ship it! Modulo Benjamin's comment. I'll fix it while committing. - Alexander Rukletsov On Aug. 24, 2018, 5:38 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68502/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2018, 5:38 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Added a new file `stout/circular_buffer.hpp` that pulls > the `boost::circular_buffer` class into the global namespace > to ensure the boost header is always used with the correct > macro definitions when included from Mesos. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 0a4ea7b16b316cc8a411ac9c4d20783530b7168a > 3rdparty/stout/include/stout/circular_buffer.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68502/diff/2/ > > > Testing > ------- > > See follow-up review r/68503. > > > Thanks, > > Benno Evers > >
