----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68441/#review207960 -----------------------------------------------------------
Fix it, then Ship it! src/master/http.cpp Lines 2524 (patched) <https://reviews.apache.org/r/68441/#comment291628> No need for this extra variable either: `IDAcceptor` takes `Option<>` as an argument. src/master/http.cpp Lines 2525 (patched) <https://reviews.apache.org/r/68441/#comment291627> Let's fix this inconsistency and pass `request.url.query.get("jsonp")` directly like you do with all other handlers. src/master/http.cpp Lines 2528 (patched) <https://reviews.apache.org/r/68441/#comment291625> `return std::move(OK(...));` src/master/master.hpp Lines 1491-1492 (original), 1496-1497 (patched) <https://reviews.apache.org/r/68441/#comment291626> // NOTE: Requests to this endpoint are batched. Or maybe even better: group batched endpoints together. - Alexander Rukletsov On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68441/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 1:16 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Added '/slaves' to the set of batched master endpoints. > > > Diffs > ----- > > src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc > src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 > > > Diff: https://reviews.apache.org/r/68441/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
