> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 1690 (original), 1700 (patched) > > <https://reviews.apache.org/r/68442/diff/1/?file=2075657#file2075657line1700> > > > > This seems inconsistent to other handlers you've introduced: you've > > been capturing `master` there.
Fixed in https://reviews.apache.org/r/68537/ > On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 1734 (original), 1744 (patched) > > <https://reviews.apache.org/r/68442/diff/1/?file=2075657#file2075657line1744> > > > > `std::move` Dropping this since we agreed in offline discussions that it would not make a difference. > On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp > > Lines 1420-1424 (patched) > > <https://reviews.apache.org/r/68442/diff/1/?file=2075658#file2075658line1420> > > > > let's keep 'em sorted Fixed in https://reviews.apache.org/r/68537/ > On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp > > Line 1464 (original), 1469 (patched) > > <https://reviews.apache.org/r/68442/diff/1/?file=2075658#file2075658line1469> > > > > // NOTE: Requests to this endpoint are batched. > > > > or grouping, see https://reviews.apache.org/r/68441/ Fixed in https://reviews.apache.org/r/68537/ - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68442/#review207961 ----------------------------------------------------------- On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68442/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 1:16 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Added '/frameworks' to the set of batched master endpoints. > > > Diffs > ----- > > src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc > src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 > > > Diff: https://reviews.apache.org/r/68442/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
