----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/#review208083 -----------------------------------------------------------
This patch seems not related to MESOS-9131? src/tests/api_tests.cpp Lines 6961 (patched) <https://reviews.apache.org/r/68231/#comment291843> I see we have called `GetParam()` at the beginning of this test, why do we need to call it here again? src/tests/api_tests.cpp Lines 7086 (patched) <https://reviews.apache.org/r/68231/#comment291844> Why do we need to count `stderrReceived` here? - Qian Zhang On Aug. 25, 2018, 6:12 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68231/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2018, 6:12 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang. > > > Bugs: MESOS-9131 > https://issues.apache.org/jira/browse/MESOS-9131 > > > Repository: mesos > > > Description > ------- > > This test verifies that we can call `ATTACH_CONTAINER_INPUT` more > than once. We send a short message first then we send a long message > in chunks. > > > Diffs > ----- > > src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 > > > Diff: https://reviews.apache.org/r/68231/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
