> On Aug. 30, 2018, 12:24 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Line 1704 (original), 1704 (patched) > > <https://reviews.apache.org/r/68232/diff/2/?file=2077426#file2077426line1705> > > > > Does it have to be `Owned`? If yes and you need to extend the lifetime > > of the promise (why?), don't you need to capture it explicitly somewhere > > then?
Yes, it does. Otherwise, `f.abandon()` will be called in `Promise` destructor. > On Aug. 30, 2018, 12:24 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 1706-1712 (patched) > > <https://reviews.apache.org/r/68232/diff/2/?file=2077426#file2077426line1707> > > > > I think you can simply say > > ``` > > promise->associate(readLoop); > > ... > > ``` Unfortunately, no. Second attempt to call `promise->associate()` is a no-op and simply returns `false`. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68232/#review208127 ----------------------------------------------------------- On Aug. 25, 2018, 10:12 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68232/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2018, 10:12 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > and Qian Zhang. > > > Bugs: MESOS-9131 > https://issues.apache.org/jira/browse/MESOS-9131 > > > Repository: mesos > > > Description > ------- > > Previously, when a corresponding nested container terminated, while the > user was attached to the container's stdin via `ATTACH_CONTAINER_INPUT` > IOSwitchboard didn't terminate immediately. IOSwitchboard was waiting > for EOF message from the input HTTP connection. Since the IOSwitchboard > was stuck, the corresponding nested container was also stuck in > `DESTROYING` state. > > This patch fixes the aforementioned issue by sending 200 `OK` response > for `ATTACH_CONTAINER_INPUT` call in the case when io redirect is > finished while reading from the HTTP input connection is not. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 52b0e521ed1c651c90b3a3df7c4df576288bf400 > > > Diff: https://reviews.apache.org/r/68232/diff/3/ > > > Testing > ------- > > 1. internal CI > 2. sudo make check (Fedora 25) > > This test fixes `LaunchNestedContainerSessionKillTask` test, which can be > found in the first patch of this patch chain. > > > Thanks, > > Andrei Budnik > >
