----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68578/#review208167 -----------------------------------------------------------
Could you fix the issues pointed out in https://reviews.apache.org/r/68576 here as well? * https://reviews.apache.org/r/68576/#comment291938 * https://reviews.apache.org/r/68576/#comment291941 * https://reviews.apache.org/r/68576/#comment291940 * https://reviews.apache.org/r/68576/#comment291942 - Benjamin Bannier On Aug. 31, 2018, 3:23 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68578/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2018, 3:23 a.m.) > > > Review request for mesos, Benjamin Bannier and James Peach. > > > Bugs: MESOS-9193 > https://issues.apache.org/jira/browse/MESOS-9193 > > > Repository: mesos > > > Description > ------- > > This patch imports the `AX_APPEND_COMPILE_FLAGS` macro and its dependent > `AX_REQUIRE_DEFINED` and `AX_APPEND_FLAG` macros to Autotools, and used > the macro to add `-Wno-unused-local-typedef` for Clang 3.6. > > The macros are retrieved from the following repository with tag > `v2014.10.15` to support Autoconf 2.59+: > http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=tree;f=m4;hb=34f91518355f1f2cba082678c60008a1ed8d009a > > > Diffs > ----- > > 3rdparty/stout/configure.ac 5de0eb02cc3270071d64bbd92f566df620ad046e > 3rdparty/stout/m4/ax_append_compile_flags.m4 PRE-CREATION > 3rdparty/stout/m4/ax_append_flag.m4 PRE-CREATION > 3rdparty/stout/m4/ax_require_defined.m4 PRE-CREATION > > > Diff: https://reviews.apache.org/r/68578/diff/3/ > > > Testing > ------- > > make check with clang 3.5.0/3.6.0. > > > Thanks, > > Chun-Hung Hsiao > >
