----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208205 -----------------------------------------------------------
Patch looks great! Reviews applied: [68495, 68555] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 29, 2018, 7:22 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68555/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2018, 7:22 a.m.) > > > Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, > and Gilbert Song. > > > Bugs: MESOS-8568 > https://issues.apache.org/jira/browse/MESOS-8568 > > > Repository: mesos > > > Description > ------- > > Previously when checker library fails to remove the previous check > container, it will discard the promise and launch a new check container > which will cause two problems: > 1. The discarded promise is used to launch the new check container, > that means even the new check container is launched successfully, > we still have no chance to process its check result since the > promise has already been discarded. > 2. The previous check container will never get a chance to be removed > which is leak, i.e., its runtime directory and sandbox directory > will not be removed. > > Now in this patch, when checker library fails to remove the previous > check container, we make it remove the previous check container again. > > > Diffs > ----- > > src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 > > > Diff: https://reviews.apache.org/r/68555/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
