> On Sept. 2, 2018, 3:37 a.m., Jie Yu wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1138 (patched) > > <https://reviews.apache.org/r/68601/diff/1/?file=2079385#file2079385line1138> > > > > you might also need VIEW_CONTAINERS because `GetContainers` will always > > show executor containers. > > Chun-Hung Hsiao wrote: > When showing the executor containers, the agent won't approve > `VIEW_CONTAINERS`, and they will be simply ignored, so it seems that > `VIEW_CONTAINERS` is not needed: > > https://github.com/apache/mesos/blob/6f010b6b61433fd783e5619ed0cada298b8fe30e/src/slave/http.cpp#L2177
IC, so basically those containers won't be shown if not authorized. This is a bit hacky, but I think it's fine for now. Let's add a TODO to the `GetContainers` API to allow us to disallow showing executor containers. In that way, we can only view standalone containers. Then, we don't have this issue. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68601/#review208234 ----------------------------------------------------------- On Sept. 3, 2018, 10:31 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68601/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2018, 10:31 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8429 > https://issues.apache.org/jira/browse/MESOS-8429 > > > Repository: mesos > > > Description > ------- > > If a CSI plugin is crashed during agent failover, the residual socket > file would exist during SLRP recovery, which may in turn make the plugin > fail to restart. This patch cleans up the residual socket files to avoid > such failures. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > ab1467c22ded269cb42fc52d3f00fb936fc42c7f > > > Diff: https://reviews.apache.org/r/68601/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
