----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/#review208417 -----------------------------------------------------------
3rdparty/libprocess/src/posix/subprocess.hpp Lines 195 (patched) <https://reviews.apache.org/r/68644/#comment292321> We need to be careful here. We are in an async-signal-safe context but hashmap and list allocate memory. Actually iterating over the directory is difficult to do in an async-signal-safe context. You can open the directory in the parent and do the iteration in the child, but I don't think there's any guarantee that the readdir in the child is safe (though AFAIK in glibc it would work). - James Peach On Sept. 6, 2018, 1:25 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68644/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 1:25 a.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Bugs: MESOS-9152 > https://issues.apache.org/jira/browse/MESOS-9152 > > > Repository: mesos > > > Description > ------- > > Closed all file descriptors except `whitelist_fds` in posix/subprocess. > > > Diffs > ----- > > 3rdparty/libprocess/src/posix/subprocess.hpp > 007058b61fdcd4716aa793516c842c3cef8c0a29 > 3rdparty/libprocess/src/subprocess.cpp > c0640de2dc4278b884282dfaad98c49c3b067a5b > > > Diff: https://reviews.apache.org/r/68644/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
