> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 278-279 (patched) > > <https://reviews.apache.org/r/68548/diff/4/?file=2079338#file2079338line278> > > > > I feel there are some ambiguities as to which parameters are > > kept/copied in the benchmark base class, which are kept just in the > > `Benchmarkconfig`, e.g. it is not clear to me why we keep the "profiles" > > here. They are not needed after the initialization phase. > > > > I wonder should we just keep a copy of the benchmarkconfig here? > > > > Any better idea?
For now, I moved it into the BenchmarkConfig. I'm not sure if there's a better place for it, but sounds reasonable to me for now. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208321 ----------------------------------------------------------- On Sept. 11, 2018, 3:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68548/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2018, 3:15 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > ------- > > The test harness encapsulates the common logic in the allocator > benchmarks such has adding frameworks and agents. One only > needs to customize the various options in the `Benchmarkconfig` > to set up the test cluster. > > > Diffs > ----- > > src/Makefile.am 0a9eeabe52b447a311de22f9772c7e90b31a6064 > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68548/diff/5/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >