----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208536 -----------------------------------------------------------
3rdparty/libprocess/configure.ac Lines 805 (patched) <https://reviews.apache.org/r/68641/#comment292534> Maybe: ``` test "x$without_bundled_libevent" = "xyes" -o "x$enable_bundled" != "xyes" ``` 3rdparty/libprocess/configure.ac Lines 1144 (patched) <https://reviews.apache.org/r/68641/#comment292533> Just a nit, I would find this more readable: ``` if test "x$enable_libevent" = "xyes" -a "x$with_bundled_libevent" != "xyes" ; then ... fi ``` - James Peach On Sept. 6, 2018, 12:32 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68641/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 12:32 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. > > > Bugs: MESOS-7076 > https://issues.apache.org/jira/browse/MESOS-7076 > > > Repository: mesos > > > Description > ------- > > Added version check and bundling of libevent within libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am f9d9d0609f5c8fed419be83319319e67afc063b7 > 3rdparty/libprocess/configure.ac e9e2434b7b6fe6c94c28744a86f9412b6302cbe0 > > > Diff: https://reviews.apache.org/r/68641/diff/1/ > > > Testing > ------- > > Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing > is ongoing. CMake updates will follow. > > > Thanks, > > Till Toenshoff > >
