> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 422 (patched) > > <https://reviews.apache.org/r/68591/diff/6/?file=2089056#file2089056line422> > > > > Is this redundant? since we already checked > > `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance` > > Kapil Arya wrote: > This is tracking total tasks across all frameworks as opposed to total > tasks per framework.
Fixed now. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208632 ----------------------------------------------------------- On Sept. 14, 2018, 3:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68591/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2018, 3:22 p.m.) > > > Review request for mesos, Meng Zhu and Till Toenshoff. > > > Bugs: MESOS-9187 > https://issues.apache.org/jira/browse/MESOS-9187 > > > Repository: mesos > > > Description > ------- > > This benchmark launches frameworks with different profiles (number of > tasks, task sizes and etc.) and prints out statistics such as total > tasks launched, cluster utilization and allocation latency. The test has > a timeout of 30 seconds > > > Diffs > ----- > > src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68591/diff/8/ > > > Testing > ------- > > ``` > [ RUN ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations > Added 80 agents in 2.727787ms > Added 554 frameworks in 33.126141ms > Start allocation > Launched 1152 tasks out of 19500 total tasks in 1 rounds. Current allocation > round generated 80 offers and took 18.470138ms > Launched 1828 tasks out of 19500 total tasks in 2 rounds. Current allocation > round generated 79 offers and took 12.000794ms > Launched 2404 tasks out of 19500 total tasks in 3 rounds. Current allocation > round generated 78 offers and took 19.469854ms > Launched 2605 tasks out of 19500 total tasks in 4 rounds. Current allocation > round generated 77 offers and took 20.271342ms > Launched 2706 tasks out of 19500 total tasks in 5 rounds. Current allocation > round generated 76 offers and took 20.172579ms > Launched 2806 tasks out of 19500 total tasks in 6 rounds. Current allocation > round generated 75 offers and took 19.731885ms > Launched 2906 tasks out of 19500 total tasks in 7 rounds. Current allocation > round generated 74 offers and took 19.9954ms > Launched 3006 tasks out of 19500 total tasks in 8 rounds. Current allocation > round generated 73 offers and took 18.969235ms > Launched 3106 tasks out of 19500 total tasks in 9 rounds. Current allocation > round generated 72 offers and took 11.915086ms > Launched 3106 tasks out of 19500 total tasks in 10 rounds. Current allocation > round generated 71 offers and took 19.106293ms > ... > Launched 3106 tasks out of 19500 total tasks in 2749 rounds. Current > allocation round generated 0 offers and took 11.747351ms > Failed to launch all tasks: Timed out after 30secs > Resource statistics: > Cluster capacity: cpus:5120; mem:39040000 > Cluster allocation: cpus:1147.6; mem:1864000 > Target allocation: cpus:2370; mem:17400000 > [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) > ``` > > > Thanks, > > Kapil Arya > >