> On May 23, 2018, 12:18 a.m., James Peach wrote: > > src/linux/fs.hpp > > Lines 294 (patched) > > <https://reviews.apache.org/r/67175/diff/1/?file=2024599#file2024599line294> > > > > This only ever gets used by the `hashset` version, so don't make it a > > static function, just call `mount` directly.
Sounds good. > On May 23, 2018, 12:18 a.m., James Peach wrote: > > src/linux/fs.hpp > > Lines 303 (patched) > > <https://reviews.apache.org/r/67175/diff/1/?file=2024599#file2024599line303> > > > > This also doesn't seem that related to the `MountInfoTable` object. > > Make it a standalone function that just does the same thing. It is actually an operation supported through `MountInfoTable` entries (but not applicable through `MountTable`). So I think it makes sense to stay within the scope of `MountInfoTable`. > On May 23, 2018, 12:18 a.m., James Peach wrote: > > src/linux/fs.cpp > > Lines 318 (patched) > > <https://reviews.apache.org/r/67175/diff/1/?file=2024600#file2024600line318> > > > > Can we write tests for this? Maybe something similar to > > `FsTest.ROOT_SlaveMount`? Will do. > On May 23, 2018, 12:18 a.m., James Peach wrote: > > src/linux/fs.cpp > > Lines 662 (patched) > > <https://reviews.apache.org/r/67175/diff/1/?file=2024600#file2024600line662> > > > > This seems like a logical extension to `os::touch`? > > > > If we can emulate the `os::stat` API and use enum constants to make > > this more obvious at the call site: > > ``` > > os::touch(path, os::Touch::RECURSIVE, os::Touch::FILE); > > ``` > > > > cc @jieyu Makes sense. I've dropped the function in this patch and will create another patch in favor of your suggestion. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67175/#review203620 ----------------------------------------------------------- On May 17, 2018, 1:23 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67175/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 1:23 a.m.) > > > Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and > Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Added utility functions for marking slave mounts in the mount table and > creating file or directory as a mount point if not already existing. > > > Diffs > ----- > > src/linux/fs.hpp 76dc09c38996eefd8487ba6ef4977ef2f7c9df4c > src/linux/fs.cpp fbd03b19abb9b56dbf3fb8a84d09a39171bbc1b0 > > > Diff: https://reviews.apache.org/r/67175/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
