----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68723/#review208661 -----------------------------------------------------------
Fix it, then Ship it! LGTM, will fix remaining issues when committing. support/verify-reviews.py Line 247 (original), 241 (patched) <https://reviews.apache.org/r/68723/#comment292778> This comment is outdated, suggest to remove. - Benjamin Bannier On Sept. 14, 2018, 9:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68723/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2018, 9:39 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9232 > https://issues.apache.org/jira/browse/MESOS-9232 > > > Repository: mesos > > > Description > ------- > > The semantics changed when the ReviewBot scripts were upstreamed; this > makes the `out_file` parameter optional, writing to stdout if not set. > > > Diffs > ----- > > support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d > > > Diff: https://reviews.apache.org/r/68723/diff/1/ > > > Testing > ------- > > Tested with `--skip-verify` on the CLI; argument is no longer required. > > > Thanks, > > Andrew Schwartzmeyer > >
