----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68730/#review208713 -----------------------------------------------------------
src/master/allocator/sorter/drf/sorter.cpp Lines 553 (patched) <https://reviews.apache.org/r/68730/#comment292870> This is assuming all clients are active? What if many clients are deactivated (suppressed)? Then this may make things worse? Can we keep tracking of the number of active/inactive nodes? Also, I find `clients.size()` to be more readable. - Meng Zhu On Sept. 16, 2018, 7:24 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68730/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2018, 7:24 p.m.) > > > Review request for mesos, Gastón Kleiman and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > 07e5482f37da8585d0313e9f70bd8105efa19533 > > > Diff: https://reviews.apache.org/r/68730/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
