----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68711/#review208720 -----------------------------------------------------------
src/python/cli_new/lib/cli/tasks.py Lines 28 (patched) <https://reviews.apache.org/r/68711/#comment292875> now that we're using python3, why not start adding type annotations? e.g. ``` def get_task(tasks: dict, task_id: str): ... ``` this will help greatly with avoiding unnecessary bugs - Eric Chung On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68711/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2018, 10:37 a.m.) > > > Review request for mesos, Eric Chung and Kevin Klues. > > > Bugs: MESOS-8795 > https://issues.apache.org/jira/browse/MESOS-8795 > > > Repository: mesos > > > Description > ------- > > Added `task ls` command to new CLI. > > > Diffs > ----- > > src/python/cli_new/lib/cli/agents.py PRE-CREATION > src/python/cli_new/lib/cli/plugins/task/main.py > 644e256ce898784ce3511c30a373595ace149db9 > src/python/cli_new/lib/cli/tasks.py PRE-CREATION > src/python/cli_new/lib/cli/tests/task.py > b54ade557f579a489e459f6022807146e0211fb0 > > > Diff: https://reviews.apache.org/r/68711/diff/6/ > > > Testing > ------- > > Tested manually and: > ``` > (mesos-cli) bash-3.2$ mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_list (cli.tests.task.TestTaskPlugin) ... ok > test_ls (cli.tests.task.TestTaskPlugin) ... ok > > ---------------------------------------------------------------------- > Ran 5 tests in 9.656s > > OK > ``` > > > Thanks, > > Armand Grillet > >
