----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68761/#review208766 -----------------------------------------------------------
This seems to be a pretty dramatic change of the API of these classes. Could you explain when and how users can safely recreate e.g., a `StorageLocalResourceProvider` with identical config (e.g., identical `workDir`)? There might be a similar issue for the `Driver`, but there mainly with external effects (e.g., `Driver` not closing connection before a similar driver reconnects). src/resource_provider/driver.cpp Line 74 (original), 75 (patched) <https://reviews.apache.org/r/68761/#comment292925> The `CHECK_NOTNULL` is redundant as above `new` would already always throw. src/resource_provider/storage/provider.cpp Lines 3846 (patched) <https://reviews.apache.org/r/68761/#comment292926> Redundant `CHECK_NOTNULL`. - Benjamin Bannier On Sept. 19, 2018, 6:53 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68761/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 6:53 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > Since the local resource provider daemon actively destructs local > resource providers, we should make the actors managed by libprocess > and avoid blocking waits during resource provider destructions. > > > Diffs > ----- > > include/mesos/v1/resource_provider.hpp > 15ede9faf96a981427ed8b3f28b170c893507bc5 > src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be > src/resource_provider/storage/provider.hpp > 5a371b19289c6e39fedd4cda65fa8be432d095e6 > src/resource_provider/storage/provider.cpp > 6475f653263337c381b6080695d09c49e5ea8fcf > > > Diff: https://reviews.apache.org/r/68761/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
