----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68403/#review208818 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/xfs_quota_tests.cpp Lines 879-881 (original), 904-906 (patched) <https://reviews.apache.org/r/68403/#comment293029> Nit: move `usage()` call below the started/working "locks" checking? src/tests/containerizer/xfs_quota_tests.cpp Lines 983-985 (original), 1055-1057 (patched) <https://reviews.apache.org/r/68403/#comment293030> Ditto, move the call closer to where its result is used. - Ilya Pronin On Aug. 16, 2018, 4:52 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68403/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 4:52 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Updated the `disk/xfs` resource statistics tests to ensure that > statistics for persistent volumes are collected and published > correctly. > > > Diffs > ----- > > src/tests/containerizer/xfs_quota_tests.cpp > 2b3a2e25f5075357f090d47826698e7bb6fdf969 > > > Diff: https://reviews.apache.org/r/68403/diff/4/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
