> On May 18, 2018, 10:08 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 60 (patched) > > <https://reviews.apache.org/r/65811/diff/5/?file=2024592#file2024592line60> > > > > In fact, I'd return `Try` if it escapes the root path, this will allow > > us to avoid some silent errors in the subsequent patch (silently change the > > intended path, instead of a failure).
Done. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203453 ----------------------------------------------------------- On Sept. 21, 2018, 9:53 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 9:53 p.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Add `path::normalize` to stout for normalizing path (for POSIX only now). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 > > > Diff: https://reviews.apache.org/r/65811/diff/6/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
