> On Sept. 21, 2018, 10:53 p.m., Eric Chung wrote: > > 3rdparty/stout/include/stout/os/posix/readlink.hpp > > Lines 34 (patched) > > <https://reviews.apache.org/r/68804/diff/1/?file=2091016#file2091016line34> > > > > should the commented lines be removed?
No. If you look at the rest of the repo, it's just the convention here. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68804/#review208899 ----------------------------------------------------------- On Sept. 21, 2018, 10:34 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68804/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 10:34 p.m.) > > > Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and > Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Added `os::readlink` for reading value of a POSIX symbolic link. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/readlink.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68804/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
