----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208911 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68731', '68732']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2375/mesos-review-68732 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2375/mesos-review-68732/logs/mesos-tests.log): ``` I0922 00:58:32.127102 9460 executor.cpp:796] Shutting down I0922 00:58:32.127102 9460 executor.cpp:909] Sending SIGTERM to process tree at pid 798 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 at slave(463)@192.10.1.5:60010 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) W0922 00:58:32.127102 9120 slave.cpp:3917] Ignoring shutdown framework 4ff92165-5200-4d21-b3e7-606f190c07c5-0000 because it is terminating I0922 00:58:32.129098 2036 master.cpp:1251] Agent 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 at slave(463)@192.10.1.5:60010 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected I0922 00:58:32.130120 2036 master.cpp:3267] Disconnecting agent 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 at slave(463)@192.10.1.5:60010 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) I0922 00:58:32.130120 2036 master.cpp:3286] Deactivating agent 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 at slave(463)@192.10.1.5:60010 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) I0922 00:58:32.130120 6860 hierarchical.cpp:359] Removed framework 4ff92165-5200-4d21-b3e7-606f190c07c5-0000 I0922 00:58:32.130120 6860 hierarch[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (586 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (609 ms total) [----------] Global test environment tear-down [==========] 1052 tests from 103 test cases ran. (495994 ms total) [ PASSED ] 1049 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] HierarchicalAllocatorTest.UpdateWeight [ FAILED ] DRFSorterTest.UpdateWeight [ FAILED ] DRFSorterTest.AddChildToLeaf 3 FAILED TESTS YOU HAVE 231 DISABLED TESTS ical.cpp:795] Agent 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 deactivated I0922 00:58:32.132110 6860 containerizer.cpp:2455] Destroying container c385de0e-b282-4f21-af81-4102668b7aec in RUNNING state I0922 00:58:32.132110 6860 containerizer.cpp:3118] Transitioning the state of container c385de0e-b282-4f21-af81-4102668b7aec from RUNNING to DESTROYING I0922 00:58:32.132110 6860 launcher.cpp:166] Asked to destroy container c385de0e-b282-4f21-af81-4102668b7aec I0922 00:58:32.156147 552 containerizer.cpp:2957] Container c385de0e-b282-4f21-af81-4102668b7aec has exited I0922 00:58:32.188154 552 master.cpp:1093] Master terminating I0922 00:58:32.189256 9120 hierarchical.cpp:637] Removed agent 4ff92165-5200-4d21-b3e7-606f190c07c5-S0 I0922 00:58:32.454150 7296 process.cpp:926] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On Sept. 21, 2018, 11:24 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68732/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 11:24 p.m.) > > > Review request for mesos, Gastón Kleiman and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > This avoids making excessive map lookups each time we calculate the > share for a node in the tree. Now, when the weight is needed, the > value is cached. If the weight gets updated, we update the cached > value. This approach proved cleaner than trying to ensure freshly > constructed nodes have the right weight. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > 71352c848e812b7c499dfbf0f09dc86fac3ee8e1 > src/master/allocator/sorter/drf/sorter.cpp > a45f66ff0d77becb6f96f7ff4c288e4ab218e070 > src/master/allocator/sorter/random/sorter.hpp > 6bfeda0f0d02b4738a6d46a7798b1bf4751f0b38 > src/master/allocator/sorter/random/sorter.cpp > fc47756927a6e45183713955e819e0640318f838 > > > Diff: https://reviews.apache.org/r/68732/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
