> On March 16, 2018, 11:17 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > <https://reviews.apache.org/r/65811/diff/3/?file=1969142#file1969142line65> > > > > Can you add some tests for this? This warrents some tests. Also, please > > reach out to Andrew because this will also compile (maybe used) on windows. > > Jie Yu wrote: > if it's posix only for now, please move to posix only headers, or add an > assertion failure if this method is used on windows.
Unit tests are added in https://reviews.apache.org/r/68832/. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review199363 ----------------------------------------------------------- On Sept. 25, 2018, 12:08 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65811/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2018, 12:08 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Added `path::normalize` to normalize a given pathname and remove > redundant separators and up-level references. > > This function follows the rules described in `path_resolution(7)` > for Linux. However, it only performs pure lexical processing without > touching the actual filesystem. > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 > > > Diff: https://reviews.apache.org/r/65811/diff/8/ > > > Testing > ------- > > `make tests` with https://reviews.apache.org/r/68832/ > > > Thanks, > > Jason Lai > >
