----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68724/#review209030 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Sept. 22, 2018, 12:35 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68724/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2018, 12:35 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-8978 > https://issues.apache.org/jira/browse/MESOS-8978 > > > Repository: mesos > > > Description > ------- > > Added the ability to launch tasks with a TTY attached to mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp e0a8fc89112223c6b0516ddec0587047338fa264 > > > Diff: https://reviews.apache.org/r/68724/diff/1/ > > > Testing > ------- > > sudo bin/mesos-master.sh \ > --ip=127.0.0.1 \ > --work_dir=/var/lib/mesos > > sudo bin/mesos-agent.sh > --master=127.0.0.1:5050 \ > --work_dir=/var/lib/mesos \ > --image_providers=docker \ > --executor_environment_variables="{}" \ > --isolation="cgroups/all,filesystem/linux,docker/runtime,namespaces/pid" > > > sudo src/mesos-execute \ > --master=127.0.0.1:5050 \ > --name=tty-test \ > --docker_image=library/alpine \ > --no-shell \ > --tty \ > --command="sh -i" > > > Thanks, > > Kevin Klues > >
