----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68402/#review209058 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/xfs_quota_tests.cpp Lines 516 (patched) <https://reviews.apache.org/r/68402/#comment293327> Shouldn't be a problem for this test, but the device file that we create for these tests is only 40MB. src/tests/containerizer/xfs_quota_tests.cpp Lines 657 (patched) <https://reviews.apache.org/r/68402/#comment293328> Ditto, our device file is 40MB. - Ilya Pronin On Sept. 24, 2018, 1:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68402/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 1:15 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, > and Jiang Yan Xu. > > > Bugs: MESOS-5158 > https://issues.apache.org/jira/browse/MESOS-5158 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure that the `disk/xfs` isolator can isolate > and manage project IDs on a persistent volume. > > > Diffs > ----- > > src/tests/containerizer/xfs_quota_tests.cpp > 2b3a2e25f5075357f090d47826698e7bb6fdf969 > > > Diff: https://reviews.apache.org/r/68402/diff/5/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
