----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68880/#review209111 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Sept. 28, 2018, 4:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68880/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 4:09 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-9279 > https://issues.apache.org/jira/browse/MESOS-9279 > > > Repository: mesos > > > Description > ------- > > Since the cgroup hierarchy results won't change, it does not make sense > to compute it every time `usage` is called. It will get quite expensivie > when the host mount table is big (e.g., MESOS-8418). > > This patch uses the static local variable to cache the result. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5 > > > Diff: https://reviews.apache.org/r/68880/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
