----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68872/#review209121 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Sept. 28, 2018, 8:22 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68872/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 8:22 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-9231 > https://issues.apache.org/jira/browse/MESOS-9231 > > > Repository: mesos > > > Description > ------- > > Without `--type` option, `docker inspect` is generic and will match > against any object types. However in our case, we only care about > Docker container rather than any other object types, so we need to > add `--type=container` so that `docker inspect` will only match Docker > container. > > > Diffs > ----- > > src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113 > > > Diff: https://reviews.apache.org/r/68872/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
