----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/#review209196 -----------------------------------------------------------
Fix it, then Ship it! Thanks for tracking this down! 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp Lines 1214-1216 (patched) <https://reviews.apache.org/r/68906/#comment293523> Can you include a pointer to a ticket or something here and above for posterity? - Benjamin Mahler On Oct. 3, 2018, 1:31 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68906/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 1:31 a.m.) > > > Review request for mesos, Benjamin Mahler and James Peach. > > > Bugs: MESOS-9265 > https://issues.apache.org/jira/browse/MESOS-9265 > > > Repository: mesos > > > Description > ------- > > Up until and including libevent 2.1.5 (beta) the buffer events EV_READ > and EV_WRITE were enabled by default in the openssl related socket > setup. > > That got changed by f4b6284b8393dbabf389ddce734a30f4cdeffa17 within > libevent; the default expectancy of read and write buffer events got > removed. > > The changes in libevent in turn caused our implementation on top of it > to fail, typically directly after accept and connect calls. > > The libevent maintainer Azat Khuzhin has generously been helping us out > by debugging and fixing the incomplete setup within libprocess. > > This patch is based on Azat's suggestions from https://goo.gl/4CK3PD. > It has been validated against libevent 2.0.22, 2.1.8 and 2.2 (alpha) > on macOS 10.14.1 and Ubuntu 16.04. > > > Diffs > ----- > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > 436b38913e43233e352cf9783da8fafefa42226f > > > Diff: https://reviews.apache.org/r/68906/diff/1/ > > > Testing > ------- > > make check with and without bundled libevent. > > Tested combinations were: > macOS 10.14.1 - libevent 2.2 > macOS 10.14.1 - libevent 2.1.8 > macOS 10.14.1 - libevent 2.0.22 > Ubuntu 16.04 - libevent 2.1.8 > > > Thanks, > > Till Toenshoff > >
