----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209231 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 5:22 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68923/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2018, 5:22 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-9283 > https://issues.apache.org/jira/browse/MESOS-9283 > > > Repository: mesos > > > Description > ------- > > When futures returned by `Docker::inspect()` are discarded > frequently, agent node performance can be negatively > impacted due to the `os::killtree()` call in the discard > handler. > > This patch avoids running `docker inspect` commands through > a shell so that it's safe to use `os::kill()` when > discarding the returned futures. > > This change is being made independently from similar > changes to the rest of the Docker library so that it can be > more easily backported to previous versions, since issues > related to `Docker::inspect()` in particular have been > observed. > > > Diffs > ----- > > src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 > src/docker/docker.cpp fb39f7480045c225096e07d7d55cd3aa7b870bc5 > > > Diff: https://reviews.apache.org/r/68923/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*"` > > > Thanks, > > Greg Mann > >
