> On Oct. 5, 2018, 2:24 p.m., Till Toenshoff wrote: > > Thanks a bunch Armand. Can we please have the same for "apple-reviews.py"?
Jeez - sorry for this confusion - here some more orderly feedback: Before applying your patch: ``` Checking 1 C++ file Done processing 3rdparty/libprocess/include/process/http.hpp Total errors found: 0 Total errors found: 0 No JavaScript files to lint No Python files to lint ``` After applying your patch: ``` Checking 1 C++ file Done processing 3rdparty/libprocess/include/process/http.hpp Total errors found: 0 ``` So we still got a "total errors found: 0" - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68937/#review209265 ----------------------------------------------------------- On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68937/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 10:28 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9056 > https://issues.apache.org/jira/browse/MESOS-9056 > > > Repository: mesos > > > Description > ------- > > Removed output in mesos-style.py when linting goes well. > > > Diffs > ----- > > support/mesos-style.py 4fea6721e8e2cff37e41815c9e434b7c8740bcf8 > > > Diff: https://reviews.apache.org/r/68937/diff/1/ > > > Testing > ------- > > Posted this review request, which uses the script due to the Git hook: > ``` > ? apache-mesos (MESOS-9056) ? git commit -m "Removed output in > mesos-style.py when linting goes well." > Checking 1 Python file > [MESOS-9056 a0c5c6568] Removed output in mesos-style.py when linting goes > well. > 1 file changed, 3 insertions(+), 3 deletions(-) > ``` > > > Thanks, > > Armand Grillet > >
