----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209300 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 692-696 (patched) <https://reviews.apache.org/r/68929/#comment293607> Indent seems not correct. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 689-691 (original), 707-709 (patched) <https://reviews.apache.org/r/68929/#comment293608> Could you add the `containerId` in this message like what you did in the above one? - Qian Zhang On Oct. 6, 2018, 7:30 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68929/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2018, 7:30 a.m.) > > > Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod > Kone. > > > Bugs: MESOS-9295 > https://issues.apache.org/jira/browse/MESOS-9295 > > > Repository: mesos > > > Description > ------- > > If there are new cgroup subsystems are added after the agent upgrad > or recovery, new nested container launched under old containers that > are launched before the recovery would fail, because it cannot assign > its pid to the non-existed cgroup hierarchy. We should skip those > new cgroup subsystems for nested containers under old containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 11dfbab182487c45fa494c41e31f777272b4b5d0 > > > Diff: https://reviews.apache.org/r/68929/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
