----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209386 -----------------------------------------------------------
PASS: Mesos patch 68706 was successfully built and tested. Reviews applied: `['68706']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2442/mesos-review-68706 - Mesos Reviewbot Windows On Oct. 9, 2018, 1:45 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68706/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2018, 1:45 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-9178 > https://issues.apache.org/jira/browse/MESOS-9178 > > > Repository: mesos > > > Description > ------- > > During the master failover, the time that the master elected is > considered as the start of failover. In the progress of > reregistration, the percentile represents the time when such > percentile of agents finished registration again; The percentile of > these data as in this metrics can represent overall reregistration > progress; In case of degradation towards to the end of reregistration, > the high percentile can reflect it; In the case there are unreachable > agents in the failover, if certain percentile recovery couldn't be > reached, the intiail value of that percentile will not be updated. > > > Diffs > ----- > > docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 > src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 > src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 > src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 > src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 > > > Diff: https://reviews.apache.org/r/68706/diff/2/ > > > Testing > ------- > > Tested in mmaster with 6 reregistration agents: > "master/slave_reregistrations": 6, > > In the middle of reregistration process: > "master/slaves_100_percent_reregistered_secs": 0, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 0, > "master/slaves_99_percent_reregistered_secs": 0, > > When all registrations finished: > "master/slaves_100_percent_reregistered_secs": 29.697210112, > "master/slaves_25_percent_reregistered_secs": 2.244662016, > "master/slaves_50_percent_reregistered_secs": 3.599491072, > "master/slaves_75_percent_reregistered_secs": 9.53919616, > "master/slaves_90_percent_reregistered_secs": 29.697210112, > "master/slaves_99_percent_reregistered_secs": 29.697210112, > > > Thanks, > > Xudong Ni > >
