----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209406 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Oct. 10, 2018, 5:21 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68970/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 5:21 a.m.) > > > Review request for mesos, Till Toenshoff and Vinod Kone. > > > Bugs: MESOS-9253 > https://issues.apache.org/jira/browse/MESOS-9253 > > > Repository: mesos > > > Description > ------- > > The error `TypeError: the JSON object must be str, not 'bytes'` was > visible when using `support/apply-reviews.py` in our CI. This issue > seems to only happen in old versions of Python 3 that are not supported > but the fix works with any version of Python 3 and allows us to not > change the Python interpreter used by reviewbot. > > > Diffs > ----- > > support/apply-reviews.py 92ad85945fb97e6ae3e21b3b9ab53c885158417e > > > Diff: https://reviews.apache.org/r/68970/diff/1/ > > > Testing > ------- > > Added the line `print(type(json_str))` in `def url_to_json(url):` to verify > that the type was now a `str` and not a `http.client.HTTPResponse`. > > > Thanks, > > Armand Grillet > >
