----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/#review209436 -----------------------------------------------------------
Ship it! Seems like we aim to backport this improvement to previous release. Could we add a unit test to simulate the cgroup root being removed issue? - Gilbert Song On Oct. 10, 2018, 10:12 p.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68986/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 10:12 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-9305 > https://issues.apache.org/jira/browse/MESOS-9305 > > > Repository: mesos > > > Description > ------- > > Created cgroup recursively when calling prepare on containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > fbb1b43a6147b4d1d1ef95e2ae1dc6b22261602a > > > Diff: https://reviews.apache.org/r/68986/diff/1/ > > > Testing > ------- > > > Thanks, > > fei long > >
