----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209492 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 828 (patched) <https://reviews.apache.org/r/68991/#comment293962> These can all be `EXPECT_TRUE`. If it compiles, could you use `EXPECT_NE`? ``` EXPECT_NE(std::find(fds->begin(), fds->end(), 0), fds->end()); ``` 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 830 (patched) <https://reviews.apache.org/r/68991/#comment293961> Maybe also add: ``` EXPECT_FALSE(std::find(fds->begin(), fds->end(), -1) != fds->end()) ``` - James Peach On Oct. 11, 2018, 1:56 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68991/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2018, 1:56 p.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Bugs: MESOS-9152 > https://issues.apache.org/jira/browse/MESOS-9152 > > > Repository: mesos > > > Description > ------- > > Added a test `FsTest.Lsof`. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > 29f06f3dd126007d6b3a81f31795270f0654b847 > > > Diff: https://reviews.apache.org/r/68991/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
