-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68994/#review209506
-----------------------------------------------------------


Ship it!




As we already discussed offline, it's a bit unfortunate to have some code 
duplication here and only have the statistics enabled for selected endpoints. 
(for those unaware, this is done in order to avoid spamming the logs with 
request statistics for every requested static html page, javascript file, css 
template, etc.)

However, with the choices being between committing this, delaying the patch 
series to implement an alternative approach, or dropping the idea entirely, I 
still think the trade-offs favor committing this since it will help to solve 
some real issues for Mesos users, and doesn't add a big maintenance burden for 
the future. So I'm giving it a 'Ship It' as is.

- Benno Evers


On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68994/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2018, 2:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, 
> Gastón Kleiman, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch leverages `logResponse()` function to print response status
> code together with the request processing time for some endpoints on
> the master and agent. Not all endpoints are participating to avoid
> unnecessary log pollution; only these that are know to be "slow" in
> generating the response.
> 
> Note that requests are still logged when they are fetched from the
> actor mailbox, i.e., affected endpoints now log twice per request:
> when the processing starts and when the response is ready to be sent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
>   src/slave/slave.cpp 9d84dcb52e5b7e507fc375f184c5f77be08d70a2 
> 
> 
> Diff: https://reviews.apache.org/r/68994/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on Mac OS 10.13.6 and various Linux distros.
> 
> Manual testing
> ==============
> Started a mesos-master process locally: `./bin/mesos-master.sh --work_dir=m`
> 
> 1. `/state` request: `http http://192.168.1.3:5050/state`
> Relevant snippet from the master log:
> ```
> I1011 16:07:05.978631 10211328 http.cpp:1178] HTTP GET for /master/state from 
> 192.168.1.3:56510 with User-Agent='HTTPie/0.9.3'
> I1011 16:07:05.981534 13430784 http.cpp:1195] HTTP GET for /master/state from 
> 192.168.1.3:56510: '200 OK' after 3.260928ms
> ```
> 
> 2. `/flags` request: `http http://192.168.1.3:5050/flags`
> Relevant snippet from the master log:
> ```
> I1011 16:08:51.012370 63365120 http.cpp:1178] HTTP GET for /master/flags from 
> 192.168.1.3:56629 with User-Agent='HTTPie/0.9.3'
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to