----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review209608 -----------------------------------------------------------
Fix it, then Ship it! src/linux/ns.cpp Lines 274 (patched) <https://reviews.apache.org/r/63655/#comment294136> Use `template <` instead. src/linux/ns.cpp Lines 277 (patched) <https://reviews.apache.org/r/63655/#comment294137> Remove two spaces. src/linux/ns.cpp Line 356 (original), 368 (patched) <https://reviews.apache.org/r/63655/#comment294138> Fits on a single line. - Benjamin Bannier On Oct. 1, 2018, 7:37 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63655/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2018, 7:37 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8156 > https://issues.apache.org/jira/browse/MESOS-8156 > > > Repository: mesos > > > Description > ------- > > Started using to `net::socketpair` in `ns::clone` so that we don't > have to deal with `SOCK_CLOEXEC` portability. > > > Diffs > ----- > > src/linux/ns.cpp ffa9b65b7caf891a5bee1e20be128c37487335e4 > > > Diff: https://reviews.apache.org/r/63655/diff/3/ > > > Testing > ------- > > make check (Fedora 26, macOS) > > > Thanks, > > James Peach > >
