----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209670 -----------------------------------------------------------
PASS: Mesos patch 69032 was successfully built and tested. Reviews applied: `['69032']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2478/mesos-review-69032 - Mesos Reviewbot Windows On Oct. 16, 2018, 11:16 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69032/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2018, 11:16 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-9325 > https://issues.apache.org/jira/browse/MESOS-9325 > > > Repository: mesos > > > Description > ------- > > Currently, `Resources::filter()` operation uses `add()` which > scans the resources vector, a O(n) operation. This is not > necessary. `filter()` operation should only remove `Resource` > entires. This patch optimizes the performance by directly > `push_back` the resource to the vector without scanning. > > > Diffs > ----- > > src/common/resources.cpp f0f3df579550d874e477e2d6e7d0e87df079358a > src/v1/resources.cpp 4d2b64f6e30ef96b47fc0b72b00158864e245650 > > > Diff: https://reviews.apache.org/r/69032/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >