----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69041/#review209708 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/future.hpp Line 710 (original), 710-714 (patched) <https://reviews.apache.org/r/69041/#comment294255> This comment seems a little confusing given there's now the default ones mixed in here? How about: ``` Promise(); virtual ~Promise(); explicit Promise(const T& t); Promise(Promise&& that) = default; Promise& operator=(Promise&&) = default; // Not copyable, not assignable. Promise(const Promise& that) = delete; Promise& operator=(const Promise&) = delete; ``` Not for this review if you don't want, but looks like we should add explicit construction from `T&&`? - Benjamin Mahler On Oct. 16, 2018, 10:23 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69041/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2018, 10:23 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Repository: mesos > > > Description > ------- > > This patch enables construction and assignment from rvalues for > `Promise` values. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > ba2120190ad6e6814ab268f3e00911904e739e8e > > > Diff: https://reviews.apache.org/r/69041/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
