> On Oct. 22, 2018, 8:42 a.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 2200-2201 (patched) > > <https://reviews.apache.org/r/69110/diff/2/?file=2101740#file2101740line2200> > > > > Let's add a `TODO` here for `CheckInfo`. Here and below.
I went ahead and modified `MasterAPITest.Subscribe` to verify the TASK_ADDED event, PTAL. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69110/#review209842 ----------------------------------------------------------- On Oct. 22, 2018, 6:20 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69110/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 6:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Vinod Kone. > > > Bugs: MESOS-8780 > https://issues.apache.org/jira/browse/MESOS-8780 > > > Repository: mesos > > > Description > ------- > > Added task health check definitions to master API responses. > > > Diffs > ----- > > include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17 > include/mesos/v1/mesos.proto c6c1dae5494d9270a7a43a2d838769574ae47872 > src/common/http.cpp 80848aafe27eb0c35222ad236e671a32c4ab10aa > src/common/protobuf_utils.cpp 77139d8a3931dc1e9e00fcea83d77d96244a34f3 > src/tests/api_tests.cpp c681b9b0b83f7472312083730a5433e3d6f0efc0 > src/tests/health_check_tests.cpp c972b9003196b4b4272d7c34311c84c117b1ae3d > > > Diff: https://reviews.apache.org/r/69110/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
